feat: update latest input data #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you test if we can update pandas, or does it break something? If we can, maybe let's update in a separate PR before. |
|
I tried updating pandas but as bhepop2 also requires pandas at 1.5.3 this creates a conflict. We would need to update pandas on bhepop2 first then we can update it on eqasim as well. |
|
With @MarieMcLaurent and @leo-desbureaux-tellae, we suggest to follow these steps in order to quickly have lastest data, except for Filosofi.
|
sebhoerl
approved these changes
Dec 30, 2024
|
Looks good, please merge in the latest changes :) |
added 2 commits
January 6, 2025 16:08
MarieMcLaurent
changed the title
MarieMcLaurent
changed the title
Nitnelav
pushed a commit
to Symexpo/eqasim-france
that referenced
this pull request
Jan 20, 2025
* feat : update data path and name * feat : change test & docs * fix : date BD-TOPO * fix : rectify test * fix : Changelog conflict * fix : change fix --------- Co-authored-by: Marie Laurent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #288
Closes #281
Updates:
We couldn't update Filosofi 2019 to Filosofi 2021 because file unreadable with actual version of Pandas (1.5.3)
(Needs
calamineas engine forread_excelbut only implement with Pandas 2.2 and above)