chore: ensuring simulations are deterministic in tests #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 22, 2024 07:51
|
@sebhoerl I had to add a line in RunInsertVehicles because MATSim's vehicle writer wants a networkMode. |
sebhoerl
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds some testing in the core module to ensure running the same simulation twice produces the same plans. The test do not cover the output events, but we noticed that two events file from a same simulation differ only in the order in which some events are written in some steps.
To ensure that the tests pass here, the MATSim version is updated to a PR that fixes a determinism issue with SwissRailRaptor.