Skip to content

Chore: Moving VDF to core and some fixes #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Aug 27, 2024
Merged

Chore: Moving VDF to core and some fixes #233

merged 12 commits into from
Aug 27, 2024

Conversation

tkchouaki
Copy link
Collaborator

@tkchouaki tkchouaki commented Jul 8, 2024

Besides Moving the VDF functionality from the VDF module to the core one, this PR does the following:

  • VDFEngine expects PlanAgent agents, this is true for most simulations but in some cases, as when DRT is used, this is not the case. This case is now handled but generateNetworkEvents needs to be set to true.
  • The modes set objects in VDFConfigGroup and VDFEngineConfigGroup were initialized with immutable sets, which causes an exception to be thrown in the call to .clear() in the string setters. They have been replaced to mutable ones.
  • The VDF and VDFEngine config groups are now detected automatically in the EqasimConfigurator and activated
  • An AdaptConfigForVDF class is added, does the typical addition of the VDF and VDFEngine config groups
  • The VDF functionality is now tested

Closes #236.

@tkchouaki tkchouaki requested a review from sebhoerl July 8, 2024 16:03
@balacmi balacmi linked an issue Jul 9, 2024 that may be closed by this pull request
@tkchouaki tkchouaki merged commit 431fba7 into develop Aug 27, 2024
1 check passed
@tkchouaki tkchouaki deleted the vdf branch August 27, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: VDF not working when using config to configure
2 participants