Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for maps to test equality of key/values #242

Closed
wants to merge 1 commit into from

Conversation

mrnovalles
Copy link

No description provided.

@eproxus
Copy link
Owner

eproxus commented Nov 15, 2023

Hi @mrnovalles! Long time no see 😉 Thanks for the PR! 🙌

@eproxus eproxus self-requested a review November 15, 2023 14:35
Copy link
Owner

@eproxus eproxus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment for why this test is needed? Also (depending on the reason) would it make sense to test with unequal maps?

@mrnovalles
Copy link
Author

mrnovalles commented Nov 22, 2023

Hey! I'm sorry this was not supposed to show up this early.
The test was related to this other issue or probably non-issue in Elixir's mock: jjh42/mock#141
And I wanted to prove how mock's args test worked with maps

@eproxus
Copy link
Owner

eproxus commented Nov 23, 2023

Ah, I'll close this PR for now then 😄 Feel free to re-open it (or a new one) if you have something you want to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants