Do not attempt to generate dependencies when mocking #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build is failing on OTP 17, but this does not seem to be related to this PR. |
eproxus
reviewed
Feb 2, 2020
src/meck_code.erl
Outdated
| @@ -121,13 +121,21 @@ load_binary(Name, Binary) -> | |||
|
|
|||
| % parse transforms have already been applied to the abstract code in the | |||
| % module, and often are not always available when compiling the forms, so | |||
| % filter them out of the options. | |||
| % filter them out of the options | |||
There was a problem hiding this comment.
One minor nitpick, could you add back the removed dot? 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The erlc option
-MMDwill cause the compiler to generate dependencies as a side-effect. This also putsmakedep_side_effectinto the beam file, causing Meck to use it when recompiling. This causes (or may cause) the mocking to fail if e.g. the destination directory specified by{makedep_output, ...}is not found.