-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python3 mike #4
Open
BikeMikeAU
wants to merge
18
commits into
eppye-bots:master
Choose a base branch
from
BikeMikeAU:python3-mike
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Python3 mike #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced media/admin with a new version from Django, this fixes a lot of upgrade issues. 1.8 will be minimum version supported now. Also created a few new svg icons in the images folder to replace the old gifs.
Found during testing
syntax error indent
fix ini key for daily logging to match botsinit.py print to console all severe errors
First ran 2to3, then made some manual fixes. There is some code to allow backwards compatibility with python 2 but unlikely it will fully work. Need to decide if Py2 is really wanted. If not, some code can be removed or improved.
Hello Mike, I downloaded your code for bots on Python 3, I created a virtual env with Python 3 and Django 1.11 yet, I tried to run the bots webserver (python bots-webserver command) but I'm getting tons of errors with missing libs, is this the right way to make it run or do you suggest some other way? or even better do you have the installer for 3.3?? Cheers, David |
Hi David,
No I haven't created an installer. You can just install dependencies
using pip. You'd need at least cherrypy and django.
Make sure your using scripts/bots-webserver.py not bots/bots-webserver.py
On 8/6/22 13:33, davidahurtado wrote:
Hello Mike,
I downloaded your code for bots on Python 3, I created a virtual env
with Python 3 and Django 1.11 yet, I tried to run the bots webserver
(python bots-webserver command) but I'm getting tons of errors with
missing libs, is this the right way to make it run or do you suggest
some other way? or even better do you have the installer for 3.3??
Cheers,
David
—
Reply to this email directly, view it on GitHub
<#4 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLHH6PNBGILE2BVR63K5UDVOALS7ANCNFSM4WPH464Q>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Kind Regards,
Mike Griffin
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates all of my changes so far to get running on Python 3 & Django 1.11