Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving how suggestions can be of use in full package reviews #140

Open
chartgerink opened this issue Nov 19, 2024 · 0 comments
Open

Improving how suggestions can be of use in full package reviews #140

chartgerink opened this issue Nov 19, 2024 · 0 comments

Comments

@chartgerink
Copy link
Member

          This is a good point, it might be worth discussing if there is a way to alleviate some of this by how we set up code reviews. For example, we could see if it is possible to create PRs that target certain sections of the code that we want reviewing. 

Often in full package or partial package reviews, even actionable suggestions cannot be committed as I work on orthogonal branches which I then make the same change as suggested and add a co-author to the commit, and the review PR is closed without merging.

It would be great if we could offer some potential solutions within this blogpost, but it's definitely not a blocker to getting it published.

Originally posted by @joshwlambert in epiverse-trace/epiverse-trace.github.io#335 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant