Alternative approach to simplifying load_survey() and fixing out-of-memory issues (#71)
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbfnk
changed the title
load_survey() and fixing out-of-memory issues (#71)
Bisaloo
reviewed
Nov 23, 2022
sbfnk
force-pushed
the
simplify-load_survey-2
branch
from
9abb305 to
61358c7
Compare
sbfnk
force-pushed
the
simplify-load_survey-2
branch
from
da9c9e5 to
61358c7
Compare
sbfnk
force-pushed
the
simplify-load_survey-2
branch
2 times, most recently
from
4073c79 to
bba3cc1
Compare
Since we can already detect if some ids from the main survey are absent from file by comparing test_merge to file
This avoids the situation where the common_id is not unique, which would make the merge fail. This issue was side-stepped with allow.cartesian = TRUE but it could make the dataset blow up and cause memory saturation
Co-authored-by: Sebastian Funk <[email protected]>
sbfnk
force-pushed
the
simplify-load_survey-2
branch
from
bba3cc1 to
c489d8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targeting #71 for clarity but could be merged into
maindirectly. Just needs aNEWSitem.Co-authored-by: Sebastian Funk [email protected]