Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lintr for automated PR reviews #69

Merged
merged 11 commits into from
Nov 16, 2022
Merged

Add lintr for automated PR reviews #69

merged 11 commits into from
Nov 16, 2022

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Nov 3, 2022

No description provided.

Copy link
Collaborator

@sbfnk sbfnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. How do you feel about a linter for max 80 characters per line? I tend to try and stick with it (if not consistently in this package) but perhaps it's not needed.

@sbfnk
Copy link
Collaborator

sbfnk commented Nov 14, 2022

Looking over the code, the another good linter might be for snake_case variable names.

@Bisaloo
Copy link
Member Author

Bisaloo commented Nov 15, 2022

Yes, feel free to re-enable object_name_linter and line_length_linter. I didn't do it here because it requires too many changes in the existing code.

If you want to fix the current code and re-enable these linters, I would recommend you start by re-enabling the relevant linter, then run lintr::lint_package() and you should get a list of all the lines to fix.

Also note that line_length_linter can be configured to another value than 80 characters.

@Bisaloo Bisaloo merged commit 6e508a6 into main Nov 16, 2022
@Bisaloo Bisaloo deleted the lintr branch November 16, 2022 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants