Skip to content

fix names #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix names #920

merged 1 commit into from
Sep 24, 2024

Conversation

nikosbosse
Copy link
Collaborator

Fixes names in our Description file.

I got an email:

Dear maintainer,

Your package contains the following persons in its DESCRIPTION
Authors@R field which have no family name, but likely should have one:

given family email orcid role
37799 Sam Abbott [email protected] 0000-0001-8057-8037 aut
37801 Johannes Bracher [email protected] 0000-0002-3777-1410 ctb
comment package
37799 scoringutils
37801 scoringutils

Please note that if a person has given name 'John' and family name 'Doe',
you should write person("John", "Doe") and not person("John Doe").

Please correct before 2024-09-30 to safely retain your package on CRAN.

@nikosbosse nikosbosse requested a review from seabbs September 24, 2024 09:30
@seabbs seabbs merged commit 4335407 into main Sep 24, 2024
9 checks passed
@seabbs seabbs deleted the fix-names branch September 24, 2024 13:16
sbfnk pushed a commit that referenced this pull request Sep 25, 2024
@nikosbosse @sbfnk
fix names (#920)
0df4173
sbfnk added a commit that referenced this pull request Sep 25, 2024
@sbfnk @nikosbosse
908: Flexible model column (#915)
06ab379 
* remove check for model column

* remove default from summarise scores

* split `by` argument to `pairwise_comparison()`

* update unit tests

* add global

* update documentation

* fix check errors

* update manuscript

* add warnings if `compare`/`by` is unset

* update tests

* add test and fix bug

* improve explanation in the docs

Co-authored-by: Nikos Bosse <[email protected]>

* restore model default

* fix names (#920)

* #896 Update documentation of log score (#918)

* use neg_log_score

* update docs, revert previous change

* update docs

---------

Co-authored-by: Nikos Bosse <[email protected]>
Co-authored-by: nikosbosse <[email protected]>
This was referenced Oct 7, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikosbosse @seabbs