Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 553: interval_coverage_ testing improvements #554

Merged
merged 8 commits into from
Jan 5, 2024

Conversation

seabbs
Copy link
Contributor

@seabbs seabbs commented Jan 5, 2024

Description

This PR closes #553

As it says on the tin adds some safety unit tests

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@seabbs seabbs changed the base branch from main to develop January 5, 2024 12:20
@seabbs seabbs requested a review from nikosbosse January 5, 2024 12:20
@seabbs seabbs changed the title Issue 553: Test metrics quantile Issue 553: interval_coverage_ testing improvements. Jan 5, 2024
@seabbs seabbs changed the title Issue 553: interval_coverage_ testing improvements. Issue 553: interval_coverage_ testing improvements Jan 5, 2024
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (545b40c) 83.71% compared to head (85733bf) 84.30%.

❗ Current head 85733bf differs from pull request most recent head 520785d. Consider uploading reports for the commit 520785d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #554      +/-   ##
===========================================
+ Coverage    83.71%   84.30%   +0.58%     
===========================================
  Files           22       21       -1     
  Lines         1726     1720       -6     
===========================================
+ Hits          1445     1450       +5     
+ Misses         281      270      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikosbosse
Copy link
Contributor

Looks good, thank you!

@nikosbosse nikosbosse merged commit e3bf253 into develop Jan 5, 2024
9 of 10 checks passed
@nikosbosse nikosbosse deleted the test-metrics-quantile branch January 5, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve unit test coverage of interval_coverage_ functions
2 participants