Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #519: Fix rendering the Readme #526

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Issue #519: Fix rendering the Readme #526

merged 5 commits into from
Dec 7, 2023

Conversation

nikosbosse
Copy link
Contributor

Description

This PR closes #519

Rendering the Readme currently fails due to an untracked file README.html. This PR adds the file to the .gitignore file, hopefully resolving the issue.

Is there a way to test this change before merging?

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@nikosbosse nikosbosse requested a review from sbfnk December 6, 2023 22:47
Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (413d427) 90.92% compared to head (518af31) 90.92%.

❗ Current head 518af31 differs from pull request most recent head d3fb96e. Consider uploading reports for the commit d3fb96e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #526   +/-   ##
=======================================
  Coverage   90.92%   90.92%           
=======================================
  Files          23       23           
  Lines        1399     1399           
=======================================
  Hits         1272     1272           
  Misses        127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbfnk
Copy link
Contributor

sbfnk commented Dec 7, 2023

Is there a way to test this change before merging?

Actions tab -> choose render readme in list on left -> Run workflow button -> select fix-render-readme branch -> run workflow

Seems to not warrant a version increment?

@seabbs
Copy link
Contributor

seabbs commented Dec 7, 2023

Seems to not warrant a version increment?

Agree as this is just CI changes

It would need a dev version (i.e a 4th large number) if it were code related to prevent pkgdown updating and so people could delineate between what is on CRAN and main

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikosbosse nikosbosse merged commit dd0de3e into main Dec 7, 2023
@nikosbosse nikosbosse deleted the fix-render-readme branch December 7, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Render Readme fails
4 participants