Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an S3 method for plot_avail_forecasts #322

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

nikosbosse
Copy link
Contributor

Does what it says on the tin :)

Reviewers suggested to create S3 methods for plotting functions and this is the start for a single function. Ideally we should finally tackle the S3 overhaul that @seabbs has been suggesting for ages.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

R/plot.R Outdated Show resolved Hide resolved
@nikosbosse nikosbosse merged commit 184c5bc into scoringutils-review4 Sep 5, 2023
@nikosbosse nikosbosse deleted the s3_plot_avail_forecasts branch September 5, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants