Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ..density.. by after_stat(density) #319

Merged
merged 3 commits into from
Sep 4, 2023

Conversation

nikosbosse
Copy link
Contributor

This PR addresses one of the issues raised by a recent review of the package as part of a submission to the Journal of Statistical Software (JSS).

The ..density.. notation is deprecated in ggplot2 and this PR replaces it by after_stat(density)

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikosbosse nikosbosse merged commit 3679c99 into scoringutils-review Sep 4, 2023
@nikosbosse nikosbosse deleted the scoringutils-review2 branch September 4, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants