Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify which column name clashes with metrics #239

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Conversation

Bisaloo
Copy link
Member

@Bisaloo Bisaloo commented Jun 20, 2022

Fix #238

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #239 (63b45a9) into master (f356634) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
+ Coverage   91.21%   91.25%   +0.03%     
==========================================
  Files          22       22              
  Lines        1355     1361       +6     
==========================================
+ Hits         1236     1242       +6     
  Misses        119      119              
Impacted Files Coverage Δ
R/check_forecasts.R 87.38% <100.00%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f356634...63b45a9. Read the comment docs.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me aside from the tiny linting issues.

@nikosbosse
Copy link
Contributor

Very nice, thanks a lot!

@nikosbosse nikosbosse merged commit ea2669f into master Jun 28, 2022
@Bisaloo Bisaloo deleted the fix-238 branch July 4, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants