Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use deparse instead of deparse1 #237

Merged
merged 4 commits into from
Jun 1, 2022
Merged

use deparse instead of deparse1 #237

merged 4 commits into from
Jun 1, 2022

Conversation

nikosbosse
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #237 (4255507) into master (ec05742) will not change coverage.
The diff coverage is 50.00%.

❗ Current head 4255507 differs from pull request most recent head 6f6e815. Consider uploading reports for the commit 6f6e815 to get more accurate results

@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   91.21%   91.21%           
=======================================
  Files          22       22           
  Lines        1355     1355           
=======================================
  Hits         1236     1236           
  Misses        119      119           
Impacted Files Coverage Δ
R/input-check-helpers.R 76.62% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec05742...6f6e815. Read the comment docs.

@nikosbosse nikosbosse requested a review from Bisaloo June 1, 2022 12:22
#' scoringutils:::check_not_null("argument" = argument)
#' paste("Input:", argument)
#' }
#' test_function("works")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRAN doesn't like examples on non-exported functions. Even though it might pass under their radar, it's probably safer to add a #' @noRd somewhere.

@nikosbosse nikosbosse merged commit f356634 into master Jun 1, 2022
@nikosbosse nikosbosse deleted the fix-deparse branch June 1, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants