Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address some of the points in Hugo's review #149

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Conversation

nikosbosse
Copy link
Contributor

  • available metrics are now exported to the user
  • == TRUE statements have been removed. These were now replaced with isTRUE as all.equal doesn't return TRUE/FALSE

@nikosbosse nikosbosse requested a review from Bisaloo November 22, 2021 10:29
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #149 (2d96ec5) into master (29ac025) will not change coverage.
The diff coverage is 60.00%.

❗ Current head 2d96ec5 differs from pull request most recent head 35901b7. Consider uploading reports for the commit 35901b7 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   48.44%   48.44%           
=======================================
  Files          18       18           
  Lines        1348     1348           
=======================================
  Hits          653      653           
  Misses        695      695           
Impacted Files Coverage Δ
R/eval_forecasts_continuous_integer.R 69.64% <0.00%> (ø)
R/pairwise-comparisons.R 42.36% <0.00%> (ø)
R/plot.R 0.00% <0.00%> (ø)
R/utils.R 63.49% <ø> (ø)
R/bias.R 87.93% <100.00%> (ø)
R/eval_forecasts.R 66.07% <100.00%> (ø)
R/pit.R 56.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29ac025...35901b7. Read the comment docs.

@nikosbosse nikosbosse merged commit 2a5dc03 into master Nov 24, 2021
@nikosbosse nikosbosse deleted the address-review branch November 24, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants