Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot order #784

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Plot order #784

merged 3 commits into from
Sep 20, 2024

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Sep 20, 2024

Description

This PR closes #783.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@sbfnk sbfnk enabled auto-merge September 20, 2024 09:59
NEWS.md Outdated Show resolved Hide resolved
@jamesmbaazam
Copy link
Contributor

@sbfnk Unrelated to this PR but two questions/comments on the plotting method:

  • Why is cumulative TRUE by default? I think when we have an uncertain distribution, the plot is quite busy. This leads to my next comment:
  • I would suggest using color instead of line types to differentiate between pmf and cmf. Since there are only two levels, the color aesthetic plays nicely with the current default of "cumulative = TRUE" for uncertain distributions.

@sbfnk
Copy link
Contributor Author

sbfnk commented Sep 20, 2024

Thanks @jamesmbaazam - please approve the PR if good to merge.

@sbfnk sbfnk added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 20, 2024
@sbfnk sbfnk added this pull request to the merge queue Sep 20, 2024
Merged via the queue into main with commit 854b23e Sep 20, 2024
9 checks passed
@sbfnk sbfnk deleted the plot-order branch September 20, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order looks wrong in distribution plot
2 participants