-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional GP kernels #741
Conversation
Nice! Very exciting |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if b4c211c is merged into main:
|
(reference for the maths is the approximate hilbert space gp paper https://arxiv.org/abs/2004.11408 on p.4 - perhaps something we should mention somewhere) |
We should cite and discuss this tutorial: https://avehtari.github.io/casestudies/Motorcycle/motorcycle_gpcourse.html#4_Heteroskedastic_GP_with_Hilbert_basis_functions It also looks to contain a better way to set L and a way to directly build the diagonal matrix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I've just looked at the code side so far and will look at the maths side tomorrow.
I think as is is fine but the Aki tutorial suggests there are now faster/more direct ways to write this and potentially some better approaches to parameterise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to look at other parameterisations in another PR. I think this looks good for now. Maths makes sense to me.
Description
This PR introduces additional GP kernels: Ornstein-Uhlenbeck and Matérn 5 / 2, for more modelling choices especially for forecasting.
Someone would have to check the maths is correct before this is merged.
Initial submission checklist
My PR is based on a package issue and I have explicitly linked it.not fixing issue but an extension of functionalitydevtools::test()
anddevtools::check()
).devtools::document()
).lintr::lint_package()
).After the initial Pull Request