Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return epinow()'s "timing" output as <difftime> #688

Merged
merged 9 commits into from
Jun 7, 2024
Merged

Return epinow()'s "timing" output as <difftime> #688

merged 9 commits into from
Jun 7, 2024

Conversation

jamesmbaazam
Copy link
Contributor

@jamesmbaazam jamesmbaazam commented Jun 5, 2024 •
edited
Loading

Description

This PR closes #687.

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

sbfnk
sbfnk requested changes Jun 6, 2024
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
R/summarise.R Show resolved Hide resolved
jamesmbaazam and others added 2 commits June 6, 2024 11:55
@jamesmbaazam jamesmbaazam changed the title Print units of model run time Return epinow()'s "timing" output as <difftime> Jun 6, 2024
@sbfnk sbfnk enabled auto-merge (squash) June 6, 2024 11:03
@jamesmbaazam jamesmbaazam disabled auto-merge June 6, 2024 17:15
@jamesmbaazam jamesmbaazam enabled auto-merge (squash) June 6, 2024 17:16
@jamesmbaazam jamesmbaazam disabled auto-merge June 7, 2024 11:48
@jamesmbaazam jamesmbaazam merged commit 916a988 into main Jun 7, 2024
9 checks passed
@jamesmbaazam jamesmbaazam deleted the timing-units branch June 7, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbfnk sbfnk sbfnk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

epinow()'s "timing" output should include units
2 participants
@jamesmbaazam @sbfnk