Get parameters #646
Merged
Get parameters #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmbaazam
reviewed
May 2, 2024
jamesmbaazam
reviewed
May 2, 2024
jamesmbaazam
previously approved these changes
May 2, 2024
There was a problem hiding this comment.
Thanks, @sbfnk. The new accessors will make the distribution interface easier to interact with.
I've suggested a few changes that can be addressed or left for latter refactoring to move forward this release.
jamesmbaazam
reviewed
May 2, 2024
jamesmbaazam
previously approved these changes
May 2, 2024
jamesmbaazam
approved these changes
May 2, 2024
jamesmbaazam
approved these changes
May 2, 2024
sbfnk
added a commit
that referenced
this pull request
May 3, 2024
* add functions for accessing parts of `dist_spec()` * update use to get_ functions * add news item * set max when constructing parametric dist_spec * add PR number and reviewer Co-authored-by: James Azam <[email protected]> * clearer get_dist_spec_id function * update documentation --------- Co-authored-by: James Azam <[email protected]>
sbfnk
added a commit
that referenced
this pull request
May 3, 2024
* add functions for accessing parts of `dist_spec()` * update use to get_ functions * add news item * set max when constructing parametric dist_spec * add PR number and reviewer Co-authored-by: James Azam <[email protected]> * clearer get_dist_spec_id function * update documentation --------- Co-authored-by: James Azam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #645 by introducing
get_parameters(),get_pmf()andget_distribution()functions that access elements of<dist_spec>objects.Initial submission checklist
devtools::test()anddevtools::check()).devtools::document()).lintr::lint_package()).After the initial Pull Request