Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move prior weights to model arguments #450

Merged
merged 5 commits into from
Sep 8, 2023
Merged

move prior weights to model arguments #450

merged 5 commits into from
Sep 8, 2023

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Sep 8, 2023

Closes #447

@sbfnk
Copy link
Contributor Author

sbfnk commented Sep 8, 2023

Not adding a deprecation warning as dist_skel was only introduced in this same version.

seabbs
seabbs reviewed Sep 8, 2023
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. A few small comments about naming and things.

Am I missing a stan code change for ot to weight or am I confused?

DESCRIPTION Show resolved Hide resolved
R/estimate_infections.R Outdated Show resolved Hide resolved
R/estimate_infections.R Show resolved Hide resolved
R/estimate_secondary.R Outdated Show resolved Hide resolved
sbfnk
sbfnk commented Sep 8, 2023
View reviewed changes
R/create.R Show resolved Hide resolved
seabbs
seabbs approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Happy once passing checks (which it seems to be about to be).

@sbfnk sbfnk merged commit b003127 into main Sep 8, 2023
@seabbs seabbs deleted the issue-447 branch September 11, 2023 09:49
sbfnk added a commit that referenced this pull request May 3, 2024
@sbfnk @seabbs
move prior weights to model arguments (#450)
4ea1876 
* move prior weights to model arguments

* fix typo in test

* Add PR and @seabbs to news so I can steal credit

* redoc

* rename and expand doc

---------

Co-authored-by: Sam Abbott <[email protected]>
sbfnk added a commit that referenced this pull request May 3, 2024
@sbfnk @seabbs
move prior weights to model arguments (#450)
0028686 
* move prior weights to model arguments

* fix typo in test

* Add PR and @seabbs to news so I can steal credit

* redoc

* rename and expand doc

---------

Co-authored-by: Sam Abbott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default values of prior_weight
2 participants
@sbfnk @seabbs