-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't defer negative binomial to Poisson at low levels of overdispersion #432
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Version and news please otherwise good to go - depending on CI
@@ -85,11 +79,11 @@ vector report_log_lik(int[] cases, vector reports, | |||
real sqrt_phi = 1e5; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can also drop this.
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 0fbf93e is merged into main:
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 2833027 is merged into main:
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if aad2527 is merged into main:
|
Two checks failing for apparently unrelated reasons. |
Existing comment in the stan code refers to avoiding overflows so will have to monitor that.
This also reinstates the tests for parameter recovery with the secondary model and fixes a bug where observation weights weren't used in the negative binomial model.
Closes #431
Addresses part of #429
Fixes #349