-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amend contribution guide #406
Amend contribution guide #406
Conversation
This is how benchmark results would change (along with a 95% confidence interval in relative change) if d2cd1cd is merged into main:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A few suggested edits for clarit.
Co-authored-by: Sebastian Funk <[email protected]>
Co-authored-by: Sebastian Funk <[email protected]>
Co-authored-by: Sebastian Funk <[email protected]>
Co-authored-by: Sebastian Funk <[email protected]>
Co-authored-by: Sebastian Funk <[email protected]>
Co-authored-by: Sebastian Funk <[email protected]>
Co-authored-by: Sebastian Funk <[email protected]>
Thanks, Seb. I have committed the changes. |
This is how benchmark results would change (along with a 95% confidence interval in relative change) if fd7c63a is merged into main:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note this doesn't update the dev version of the new file with the changes made.
Co-authored-by: Sebastian Funk <[email protected]>
In this PR, I add a section to explain what happens after a pull request is submitted. This information might be useful for new contributors. This fixes #404.
In the process of the submitting the PR, some words were picked up by the spelling workflow and added to the wordlist. These can be found here d65b5ef and here 74670b1.