only call truncate if truncation is modelled #304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the call to
truncate
inestimate_infections
, only calling it when truncation is actually required. This seems more intuitive as the call totruncate
was previously required even if no truncation was applied, but only to create anobs_report
variable not containing the forecasts. This now follows the same logic as e.g. only applying scaling ifobs_scale
is set to 1, such that the decision of whether truncation is applied is now happening outside thetruncate
function, which now always truncates.As a (positive, in my opinion) side effect this does away with having to pass vectors to the
truncate
function requiring declarations of vectors of size 1 inestimate_truncation
.