Changes to ObjectArg and added IdArg #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store definitions with IdArgs only so they can be passed to objects
thomascobb
reviewed
Mar 11, 2022
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 98.42% 98.44% +0.01%
==========================================
Files 8 8
Lines 318 322 +4
==========================================
+ Hits 313 317 +4
Misses 5 5
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
thomascobb
reviewed
Mar 11, 2022
- Remove yaml.schemas from settings.json, have yaml-language-server at top of yamls instead - Change back to entity_cls - Change back lookup_instance parameter
coretl
approved these changes
Mar 14, 2022
- vscode web developer tool for vscode-ibek-entities wasn't registering $data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20