Feature/entity disabled #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you put it in the baseclass too without the initial value, but remove the dataclass decorator, does that work? |
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=========================================
Coverage ? 98.06%
=========================================
Files ? 8
Lines ? 310
Branches ? 0
=========================================
Hits ? 304
Misses ? 6
Partials ? 0 Continue to review full report at Codecov.
|
BenBradnick
force-pushed
the
feature/entity-disabled
branch
from
2878ce1 to
268d59c
Compare
|
Hi @thomascobb can you take another look now that CI looks happy again? |
thomascobb
reviewed
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #19.
Currently mypy complains because the base class Entity has no attribute entity_disabled - but if I add a type hint to this class then other unit tests fail due to an argument with a default value then being defined before a non-default argument.
I could ignore the check on that line but I was wondering if there was a real fix?