Separate helm and startup commands #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
gilesknap
commented
Sep 24, 2021
gilesknap
commented
- Split build-ioc command into build-helm and build-startup
- add generic_image: into the entity yaml and propgate that to the helm chart
- add a schema specification mode line to entity yaml
- validate against the schema in build-helm
and add schema validation for build-helm command
gilesknap
force-pushed
the
multiple-support
branch
from
8e0828a to
4eccca5
Compare
|
@thomascobb sorry this PR may have got quite big. It now has the multiple definitions support. |
thomascobb
reviewed
Sep 27, 2021
Co-authored-by: Tom Cobb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.