Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional command for use in install.sh: ibek support add_runtime_folder #225

Closed
gilesknap opened this issue May 31, 2024 · 2 comments
Closed

Comments

@gilesknap
Copy link
Member

This function should do an idempotent add to a list of folders for copying into the runtime stage.

You can add folders to the runtime stage by explicitly putting them into the extract_runtime_assets function in Dockerfile. But it is much better if individual install.sh can control the list themselves.

This function would be very similar to add-dbds and add-libs but would add to the default list of things that extract_runtime_assets copies.

ALSO - extract_runtime_assets copies subfolders of each support module. The subfolder list is currently db/lib/bin - we need to add */protocol to that list in order to support streamdevices (to statically and dynamically linked modules)

@marcelldls this would be a nice issue for you to look at as you are getting into ibek's code

@amichelotti as discussed by email today.

@gilesknap gilesknap changed the title Additional command for use in install.sh: ibek support add_runtime_folder Additional command for use in install.sh: ibek ioc add_runtime_folder May 31, 2024
@gilesknap gilesknap changed the title Additional command for use in install.sh: ibek ioc add_runtime_folder Additional command for use in install.sh: ibek support add_runtime_folder May 31, 2024
@gilesknap
Copy link
Member Author

gilesknap commented May 31, 2024

PS I could not decide if this was an ioc or support namespace command. It is specifying a list for the ioc but it is a per support module thing and thus that is the correct namespace (analogous to ibek support add-dbds)

@gilesknap
Copy link
Member Author

gilesknap commented Jun 18, 2024

TODO: get this change in before release 3.0.0 (DONT FORGET */protocol)

gilesknap added a commit that referenced this issue Jun 24, 2024
add add_runtime_files function. fixes #225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant