You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description: coachMarksController:didHide reports indexes from 1 not 0 as it correctly should. (willHide for instance does report indexes correctly).
Additional details:
Regarding the incorrect indexes I have also noticed that when starting flow from UIViewController:viewWillTransition(to) (which is triggered when orientation changes) coachMarkViewsAt delegate will either report -1 index (usually when changing from Landscape to Portrait) or double 0 indexes.
Workaround which helped is to run coachMarksController.start(on: self) inside DispatchQueue.main.async. Even though I did not inspect this bug into the detail I'm pretty sure it should run correctly even without this little "workaround".
Tested on:
1.2.0
The text was updated successfully, but these errors were encountered:
The Dispatch.async solution provided by @Mattijah also solves another problem that I don't know if its considered a related bug:
The function coachMarksController:willHide is executed after coachMarksController:coachMarkAt if coachMarksController.start(on: self) is executed outside the DispatchQueue.main.async. Is this intentional? If the answer is no, I'll be happy to open a separated issue.
Description:
coachMarksController:didHide
reports indexes from1
not0
as it correctly should. (willHide
for instance does report indexes correctly).Additional details:
Regarding the incorrect indexes I have also noticed that when starting flow from
UIViewController:viewWillTransition(to)
(which is triggered when orientation changes)coachMarkViewsAt
delegate will either report-1
index (usually when changing from Landscape to Portrait) or double0
indexes.Workaround which helped is to run
coachMarksController.start(on: self)
insideDispatchQueue.main.async
. Even though I did not inspect this bug into the detail I'm pretty sure it should run correctly even without this little "workaround".Tested on:
The text was updated successfully, but these errors were encountered: