Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependsOnNot #100

Merged
merged 2 commits into from
May 17, 2020
Merged

Add dependsOnNot #100

merged 2 commits into from
May 17, 2020

Conversation

ragingdave
Copy link
Collaborator

Fixes #94

@ragingdave ragingdave changed the title Add depends not Add dependsOnNot Dec 11, 2019
@wize-wiz
Copy link
Contributor

@ragingdave Looks solid! I'll give it a test drive tonight and merge it if I have nothing else to add.

@wize-wiz
Copy link
Contributor

@ragingdave Dunn Tire? So you literally can drive your bike to the Niagara Falls?

@ragingdave
Copy link
Collaborator Author

Lol That I can and have done (of course by bike I mean motorcycle)

@ragingdave
Copy link
Collaborator Author

Any chance you've had a look?

@wize-wiz
Copy link
Contributor

@ragingdave He Dave, I'm sorry, currently I'm on tight deadlines and somehow those deadlines won't go away!...

I'll try to look into it end of the week. Are you a freelancer btw?

And didn't David Cox Jr. die in 1885? 😁

@ragingdave
Copy link
Collaborator Author

No worries got deadlines of my own too :)... I don't think I died in 1885 but who knows lol. Not a dedicated freelancer at the moment but if a cool project comes along who knows right? We all turn into freelancers then

@wize-wiz
Copy link
Contributor

@ragingdave turn into a freelancer you mean like mutating? I don't know how you guys turn into freelancers on the other side of the ocean, but if it's by mutating .. oh boy! I wish I get 6 pairs of arms!

@lopandpe
Copy link

lopandpe commented Jan 20, 2020

Hi there! Just to know, @wize-wiz could you review this? If this is going to be pulled soon, I'll wait for it <3

@ragingdave
Copy link
Collaborator Author

@wize-wiz I certainly don't want to come off as naggy....but any chance this might make it soon?

@desaintflorent
Copy link

I would be really intrested for this too.
Do you have any idea of timing ?

@ragingdave
Copy link
Collaborator Author

@wize-wiz I get that we are all busy but this isn't a huge package change, and seems like other people want/need this too. I've now gotten to the point of just using my fork in my project due to how long it's taking to get in here. I understand it's open source and you do what you can....but I mean 4-5 months....there has to be some kind of time in there for this kind of thing.

@ragingdave ragingdave merged commit 780aa9e into epartment:master May 17, 2020
@Aylarius
Copy link

Aylarius commented Jun 4, 2020

@ragingdave @wize-wiz dependsOnNot is unfortunately still not available as no new release has been created. Could you please release it? That would be super helpful!

@ragingdave
Copy link
Collaborator Author

New release should be good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ability for dependsOnNot
5 participants