Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with whitecube/nova-flexible-content #93

Closed
nilsE opened this issue Nov 17, 2019 · 3 comments
Closed

Compatibility with whitecube/nova-flexible-content #93

nilsE opened this issue Nov 17, 2019 · 3 comments

Comments

@nilsE
Copy link

nilsE commented Nov 17, 2019

Hi,

i'm trying to make a dependency inside a flexible content layout (with whitecube/nova-flexible-content), like so:

class AddressPrivateLayout extends Layout
    {
        protected $name = 'address-private';
        protected $title = 'private address';

        public function fields()
        {
            return [
                Boolean::make('Check me', 'checkme')

                NovaDependencyContainer::make([
                    Text::make('Dependent')
                ])->dependsOn('checkme', 1),

            (...)

...but nothing happens when i check the "Check me" field.
Am i doing something wrong, can you help?

Thanks,
Nils

@wize-wiz
Copy link
Contributor

@nilsE The fix is quite simple for the dependency container to work with flexible content, though another problem appears due to duplicated content. There is an issue at flexible content somewhere addressing this problem. They don't have the time to address these issues.

I haven't had the time to send a PR fixing the duplicated content issue, because it might break some stuff I don't know about.

So short story, no. I don't see a quick fix to get both packages to work together without modifying flexible contents code.

@wize-wiz
Copy link
Contributor

wize-wiz commented Dec 1, 2019

@nilsE Please verify if v1.2.10 solves the problem.

@nilsE
Copy link
Author

nilsE commented Dec 1, 2019

works - thanks a lot!!!

@nilsE nilsE closed this as completed Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants