Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SAS Date and DateTime Format Conversion #57

Closed
wants to merge 1 commit into from
Closed

Added SAS Date and DateTime Format Conversion #57

wants to merge 1 commit into from

Conversation

rifat-khanam
Copy link

No description provided.

@printsev
Copy link
Contributor

could you please provide some comments about the suggested change, i.e. what was the reasoning behind? as far as I understand, you suggest to do two things:

  1. store datetime in string rather than in object
  2. still return obtained rowElements in case something went wrong while currently null is returned

@xantorohara xantorohara mentioned this pull request Jan 1, 2021
Merged
@printsev
Copy link
Contributor

new date formats were implemented under #86

@printsev printsev closed this Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rifat-khanam @printsev