Skip to content

updating for compliance with interface #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2024
Merged

updating for compliance with interface #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
132e500
updating for compliance with interface
RonTuretzky Mar 6, 2024
bb04f0c
updating comment to reflect function rename
RonTuretzky Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ServiceManagerBase.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ abstract contract ServiceManagerBase is IServiceManager, OwnableUpgradeable {
}

/**
* @notice Sets the metadata URI for the AVS
* @notice Updates the metadata URI for the AVS
* @param _metadataURI is the metadata URI for the AVS
* @dev only callable by the owner
*/
function setMetadataURI(string memory _metadataURI) public virtual onlyOwner {
function updateAVSMetadataURI(string memory _metadataURI) public virtual onlyOwner {
_avsDirectory.updateAVSMetadataURI(_metadataURI);
}

Expand Down
4 changes: 2 additions & 2 deletions src/interfaces/IServiceManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ import {IDelegationManager} from "eigenlayer-contracts/src/contracts/interfaces/
*/
interface IServiceManager {
/**
* @notice Sets the metadata URI for the AVS
* @notice Updates the metadata URI for the AVS
* @param _metadataURI is the metadata URI for the AVS
*/
function setMetadataURI(string memory _metadataURI) external;
function updateAVSMetadataURI(string memory _metadataURI) external;

/**
* @notice Forwards a call to EigenLayer's DelegationManager contract to confirm operator registration with the AVS
Expand Down
4 changes: 2 additions & 2 deletions test/integration/CoreRegistration.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ contract Test_CoreRegistration is MockAVSDeployer {
require(operator != serviceManager.owner(), "bad test setup");
cheats.prank(operator);
cheats.expectRevert("Ownable: caller is not the owner");
serviceManager.setMetadataURI("Test MetadataURI");
serviceManager.updateAVSMetadataURI("Test MetadataURI");
}

event AVSMetadataURIUpdated(address indexed avs, string metadataURI);
Expand All @@ -180,7 +180,7 @@ contract Test_CoreRegistration is MockAVSDeployer {
cheats.prank(toPrankFrom);
cheats.expectEmit(true, true, true, true);
emit AVSMetadataURIUpdated(address(serviceManager), "Test MetadataURI");
serviceManager.setMetadataURI("Test MetadataURI");
serviceManager.updateAVSMetadataURI("Test MetadataURI");
}

// Utils
Expand Down