[Fix] mount: ensure that react-text comment nodes don’t break .find
#691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ind` - add `shallow` test just in case - use `values` over `Object.keys` in MountedTraversal Fixes enzymejs#689.
ljharb
force-pushed
the
fix_mount_comments
branch
from
d4f9e76
to
560e726
Compare
lelandrichardson
approved these changes
Nov 19, 2016
ljharb
force-pushed
the
fix_mount_comments
branch
from
560e726
to
8db9f23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #689.
shallowtest just in casevaluesoverObject.keysin MountedTraversal