Display a useful error when withDom fails to find "jsdom".
#686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Nov 17, 2016
| if (e.message === "Cannot find module 'jsdom'") { | ||
| console.error('[enzyme/withDom] Error: missing required module "jsdom"'); | ||
| console.error('[enzyme/withDom] To fix this you must run:'); | ||
| console.error('[enzyme/withDom] npm install jsdom -D'); |
There was a problem hiding this comment.
let's stick to --save-dev rather than using the shortcuts.
There was a problem hiding this comment.
Sure. I didn't feel strongly either way.
|
@ljharb updated to |
ljharb
approved these changes
Nov 18, 2016
|
Sure I can rebase and squash it. |
indexzero
force-pushed
the
withdom-noisy
branch
from
c24aa58
to
ab2d91f
Compare
indexzero
force-pushed
the
withdom-noisy
branch
from
ab2d91f
to
aaeedcf
Compare
|
All set. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lost a bunch of time on this today because I thought it was a compatibility issue around the new
[email protected]release ...... instead of just my own error of forgetting to install
jsdomin a new module. 🙀 🙀 🙀Hopefully this helps others avoid my mistake. Tried to make the message displayed to users as clear as possible. 💯 ✨ 👍 💪 😼
_