Fix valid + falsy propvalues #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…versal’s `instHasProperty`.
ljharb
force-pushed
the
fix_zero_propvalue
branch
from
bd0ed7d
to
2d9712a
Compare
|
is |
|
@nfcampos good call, i'll cover that also. |
|
and while you're at it |
|
Are |
|
Doesn't React strip out null properties? |
|
only |
|
Looks like it doesn't strip out |
|
Ready for a stamp! |
| return propValue; | ||
| } | ||
|
|
||
| if (is('NaN', propValue)) { |
There was a problem hiding this comment.
any reason this isn't propValue !== 'NaN'?
There was a problem hiding this comment.
i'll change it; i'd been using a literal NaN and then updated it to take in a string
ljharb
force-pushed
the
fix_zero_propvalue
branch
2 times, most recently
from
d00357b
to
58c58ca
Compare
ljharb
force-pushed
the
fix_zero_propvalue
branch
from
d43c1c2
to
0314e2f
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #562.
I also consolidated some code.