Throw if some() is called on a root wrapper #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. It seems like although this could be a breaking change, that since the selectors couldn't have possibly worked before, we can consider it just a bugfix. Confirm? |
|
It would have "worked" in the sense that it just tested whether the root node matched the selector, which seems like incorrect behavior for this API. So I would consider this a bugfix as well. |
pmeinhardt
added a commit
to bitcrowd/tickety-tick
that referenced
this pull request
Oct 31, 2016
Enzyme incoroporated a breaking change, which still matched our version specification for the npm package. The change caused our Travis build to fail. This commit updates the spec accordingly. See: - enzymejs/enzyme#523 - enzymejs/enzyme#510 (comment)
pmeinhardt
added a commit
to bitcrowd/tickety-tick
that referenced
this pull request
Nov 27, 2016
Enzyme incoroporated a breaking change, which still matched our version specification for the npm package. The change caused our Travis build to fail. This commit updates the spec accordingly. See: - enzymejs/enzyme#523 - enzymejs/enzyme#510 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #510 (comment) per @ljharb's recommendation.