Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the describeWithDOM label #48

Merged
merged 1 commit into from
Dec 6, 2015
Merged

Tweak the describeWithDOM label #48

merged 1 commit into from
Dec 6, 2015

Conversation

silvenon
Copy link
Contributor

@silvenon silvenon commented Dec 4, 2015

Before:

screenshot 2015-12-05 00 19 44

After:

screenshot 2015-12-05 00 18 49

@silvenon
Copy link
Contributor Author

silvenon commented Dec 4, 2015

Let me know if you'd prefer square brackets instead.

@lelandrichardson
Copy link
Collaborator

@silvenon I'm not particularly attached to one version or another... but was there something that necessitated this change for you or did you just not like the aesthetic of << >>?

@silvenon
Copy link
Contributor Author

silvenon commented Dec 5, 2015

  • aesthetics 😁
  • readability—message at the bottom is hard to read with << >> because it visually conflicts with tag marks, and << >> takes up way too much space, especially in monospace fonts (typographically « » would make more sense, but it doesn't look good either)
  • semantics—AFAIK << >> doesn't mean anything, while parenthesis suggest additional info

@lelandrichardson
Copy link
Collaborator

I don't have any problem with changing it...

@ljharb @goatslacker thoughts?

@ljharb
Copy link
Member

ljharb commented Dec 6, 2015

LGTM - it's just informational logging, so it's barely even a patch-level change :-)

@lelandrichardson
Copy link
Collaborator

OK. Since I think @silvenon's points have merit, i'm going to go ahead and merge this.

lelandrichardson added a commit that referenced this pull request Dec 6, 2015
Tweak the describeWithDOM label
@lelandrichardson lelandrichardson merged commit d1c4dab into enzymejs:master Dec 6, 2015
@silvenon
Copy link
Contributor Author

silvenon commented Dec 6, 2015

Thanks!

@silvenon silvenon deleted the patch-1 branch December 6, 2015 23:23
lelandrichardson added a commit that referenced this pull request Dec 7, 2015
- Support for Stateless Functional Components ([#53](#53))

- Tweak `describeWithDOM` messaging ([#48](#48))
- Documentation Fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants