1862/fix setprops on cdu

[ghost]

Fixes #1862

[ljharb]

Thanks, this is great!

[ghost]

No problem!!

[willdurand]

We noticed a regression in our test suite (between Enzyme 3.8 and 3.9), likely due to this patch. Downgrading to Enzyme 3.8 makes our test suite pass again.

We have some code that changes a component's state in componentWillReceiveProps() and, depending on this new state, a function is called in componentDidUpdate(). This is not working anymore and I believe this patch is the "culprit".

This PR shows the regression as well as the revert to Enzyme 3.8 to get a green CI again: mozilla/addons-frontend#7603.

I am not sure what you or I could do though. Moving away from CWRP is on our roadmap and might "fix" this incompatibility, but upgrading from 3.8 to 3.9 should not break our test suite. I don't know what's the most "correct" behavior between no batch updates, the <=3.8 behavior and the new one introduced by this patch 🤷‍♂️

[ljharb]

@willdurand thanks for the report, could you file a new issue and fill out the template?

(Note that whatever react does is going to be "correct"; so it seems like 3.9 either fixed a bug, or introduced one)