envoy.base.utils: Fix flake8 stdout/err error#108
Merged
phlax merged 1 commit intoenvoyproxy:mainfrom Oct 29, 2021
Merged
Conversation
|
✔️ Deploy Preview for nifty-bassi-e26446 ready! 🔨 Explore the source changes: 1c8a7bf 🔍 Inspect the deploy log: https://app.netlify.com/sites/nifty-bassi-e26446/deploys/617be668a4a79f0007928659 😎 Browse the preview: https://deploy-preview-108--nifty-bassi-e26446.netlify.app |
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
envoy.base.utils_flake8
branch
from
3610a4f to
1c8a7bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
switches
bufferedutil to use aTextIOWrapperrather than aStringIOdirectly and provides a better wrapping of stdout/stderrfixes a bug where flake8 is called and expects the more standard stdout/err behaviour