Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display all statsd metrics in prometheus #283

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

ysawa0
Copy link
Member

@ysawa0 ysawa0 commented Aug 11, 2021

Before, due to the "drop all" rule, statsd metrics that didn't match any rules were dropped in prom. I'm removing that so metrics not specified by a rule will be autogenerated. Should help in debugging the some of the metrics issues in #274 #275 #276
ex:

# HELP ratelimit_service_rate_limit_within_limit Metric autogenerated by statsd_exporter.
# TYPE ratelimit_service_rate_limit_within_limit counter
ratelimit_service_rate_limit_within_limit{domain="rl",key1="foo",key2="bar"} 12
# HELP ratelimit_service_response_time_seconds Metric autogenerated by statsd_exporter.
# TYPE ratelimit_service_response_time_seconds histogram
ratelimit_service_response_time_seconds_bucket{grpc_method="ShouldRateLimit",le="0.005"} 196
ratelimit_service_response_time_seconds_bucket{grpc_method="ShouldRateLimit",le="0.01"} 196

Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit b42701c into envoyproxy:main Aug 12, 2021
jespersoderlund pushed a commit to jespersoderlund/ratelimit that referenced this pull request Sep 19, 2021
@ysawa0 ysawa0 deleted the promfix branch September 29, 2021 03:47
timcovar pushed a commit to goatapp/ratelimit that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants