Skip to content

Sink tests: fix for parallel test execution #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dubious90 merged 3 commits into from
Mar 29, 2021
Merged

Sink tests: fix for parallel test execution #665

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a83238
Sink tests: fix for parallel test execution
Mar 26, 2021
37c485f
Merge remote-tracking branch 'upstream/main' into sink-parallel-test-…
Mar 27, 2021
b32ba74
Clean up tmp file in test
Mar 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/sink/sink_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

#include "sink/sink_impl.h"

#include "gmock/gmock.h"
#include "gtest/gtest.h"

namespace Nighthawk {
Expand Down Expand Up @@ -112,9 +113,9 @@ TEST(FileSinkTest, BadGuidInvalidCharacter) {

TEST(FileSinkTest, CorruptedFile) {
FileSinkImpl sink;
const std::string execution_id = "14e75b2a-3e31-4162-9279-add1e54091f9";
Envoy::Random::RandomGeneratorImpl random;
const std::string execution_id = random.uuid();
std::error_code error_code;
std::filesystem::remove_all("/tmp/nh/" + execution_id + "/", error_code);
nighthawk::client::ExecutionResponse result_to_store;
*(result_to_store.mutable_execution_id()) = execution_id;
ASSERT_TRUE(sink.StoreExecutionResultPiece(result_to_store).ok());
Expand All @@ -128,9 +129,8 @@ TEST(FileSinkTest, CorruptedFile) {
}
status = sink.LoadExecutionResult(execution_id);
ASSERT_FALSE(status.ok());
EXPECT_EQ(status.status().message(),
"Failed to parse ExecutionResponse "
"'\"/tmp/nh/14e75b2a-3e31-4162-9279-add1e54091f9/badfile\"'.");
EXPECT_THAT(status.status().message(), testing::HasSubstr("Failed to parse ExecutionResponse"));
std::filesystem::remove_all("/tmp/nh/" + execution_id + "/", error_code);
}

} // namespace
Expand Down