Fix namespace dereferencing according to the style guide#653
Merged
dubious90 merged 2 commits intoenvoyproxy:mainfrom Mar 19, 2021
Merged
Fix namespace dereferencing according to the style guide#653dubious90 merged 2 commits intoenvoyproxy:mainfrom
dubious90 merged 2 commits intoenvoyproxy:mainfrom
Conversation
Just cleanup, no functional changes. Closes envoyproxy#652 Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Member
Author
|
This does introduce a bit of code churn, if anyone anticipates having to deal with merge conflicts because of this, it's probably better to postpone this, please comment in that case. |
Contributor
|
Hey Otto, just to confirm - is this currently blocked by #647? (I am currently reviewing that one, and it appears this one is based on that one) |
dubious90
added
blocked
Member
Author
I don't think this needs to be blocked on that, this is based on the main branch. |
oschaaf
added
waiting-for-review
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Member
Author
|
Backed out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just cleanup, no functional changes.
Closes #652
Signed-off-by: Otto van der Schaaf ovanders@redhat.com