Skip to content

Update Envoy to 031f75d (Mar 14th 2021)#648

Merged
dubious90 merged 5 commits intoenvoyproxy:mainfrom
qqustc:envoy-update
Mar 16, 2021
Merged

Update Envoy to 031f75d (Mar 14th 2021)#648
dubious90 merged 5 commits intoenvoyproxy:mainfrom
qqustc:envoy-update

Conversation

@qqustc
Copy link
Copy Markdown
Contributor

@qqustc qqustc commented Mar 16, 2021

  • .bazelrc was unchanged

  • .circleci/config.yml was unchanged

  • .bazelversion was unchanged

  • ci/run_envoy_docker.sh was unchanged

  • Code changes

    • Replace factoryForGrpcService(..., Envoy::Grpc::AsyncClientFactoryClusterChecks::Skip) with factoryForGrpcService(..., /*skip_cluster_check=*/true) due to PR #15449 in Envoy
    • Delete test test_nighthawk_client_v2_api_explicitly_set and test_nighthawk_test_server_envoy_deprecated_v2_api in test/integration/test_integration_basics.py since they are broken by Envoy PR #15481
    • Delete test fixture http_test_server_fixture_envoy_deprecated_v2_api in test/integration/integration_test_fixtures.py
  • Update MAINTAINERS.md

Signed-off-by: qqustc@gmail.com qqin@google.com

qqustc added 3 commits March 15, 2021 20:59
Signed-off-by: qqustc@gmail.com <qqin@google.com>
Signed-off-by: qqustc@gmail.com <qqin@google.com>
Signed-off-by: qqustc@gmail.com <qqin@google.com>
@qqustc qqustc requested a review from mum4k March 16, 2021 01:49
@qqustc qqustc added the waiting-for-review A PR waiting for a review. label Mar 16, 2021
Signed-off-by: qqustc@gmail.com <qqin@google.com>
oschaaf
oschaaf previously approved these changes Mar 16, 2021
@dubious90 dubious90 assigned dubious90 and unassigned mum4k Mar 16, 2021
Signed-off-by: qqustc@gmail.com <qqin@google.com>
Copy link
Copy Markdown
Contributor

@dubious90 dubious90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for adding in the documentation change we discussed offline. Will merge when CI passes

@dubious90 dubious90 removed the request for review from mum4k March 16, 2021 16:37
@dubious90 dubious90 merged commit 08c2028 into envoyproxy:main Mar 16, 2021
@qqustc qqustc deleted the envoy-update branch April 19, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-review A PR waiting for a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants