Update Envoy to cfe0391 (Feb 5th 2021).#621
Merged
mum4k merged 2 commits intoenvoyproxy:mainfrom Feb 7, 2021
mum4k:envoy-update
Merged
Update Envoy to cfe0391 (Feb 5th 2021).#621mum4k merged 2 commits intoenvoyproxy:mainfrom mum4k:envoy-update
mum4k merged 2 commits intoenvoyproxy:mainfrom
mum4k:envoy-update
Conversation
- synchronizing `.bazelrc` from Envoy repository. - the API of `getJsonStringFromMessage` changed, it now returns `ProtobufUtil::StatusOr` instead of `std::string`. Switching our code over to `getJsonStringFromMessageOrDie` which continues to return `std::string`. Signed-off-by: Jakub Sobon <mumak@google.com>
oschaaf
previously approved these changes
Feb 6, 2021
Member
oschaaf
left a comment
oschaaf
left a comment
There was a problem hiding this comment.
It's almost as if CI became a bit slower to execute in the last couple of days somehow. The CI tasks we have that have historically been sensitive to that all started flaking. Here test_gcc ends with Too long with no output (exceeded 10m0s): context deadline exceeded. That seems like something that should resolve on a retry.
One question about the method that transforms messages to json for us; otherwise LGTM assuming that we just need to update the method names.
oschaaf
added
waiting-for-changes
In case this is caused by CI getting slower, or to uncover the root cause. Signed-off-by: Jakub Sobon <mumak@google.com>
Collaborator
Author
|
The |
oschaaf
approved these changes
Feb 6, 2021
Collaborator
Author
|
Thank you for filing the issue @oschaaf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.bazelrcfrom Envoy repository.getJsonStringFromMessagechanged, it now returnsProtobufUtil::StatusOrinstead ofstd::string. Switching our code over togetJsonStringFromMessageOrDiewhich continues to returnstd::string.no_output_timeoutparameter to 30m for test_gcc which was timing out.Signed-off-by: Jakub Sobon mumak@google.com