Update Envoy to 9753819 (Jan 24th 2021).#607
Merged
mum4k merged 2 commits intoenvoyproxy:mainfrom Jan 26, 2021
mum4k:envoy-update
Merged
Update Envoy to 9753819 (Jan 24th 2021).#607mum4k merged 2 commits intoenvoyproxy:mainfrom mum4k:envoy-update
mum4k merged 2 commits intoenvoyproxy:mainfrom
mum4k:envoy-update
Conversation
- tryCreateNewConnection now returns a ConnPoolImplBase::ConnectionResult instead of a bool. Signed-off-by: Jakub Sobon <mumak@google.com>
oschaaf
approved these changes
Jan 25, 2021
Member
oschaaf
left a comment
oschaaf
left a comment
There was a problem hiding this comment.
LGTM, assuming that the PR that updates the docker version we use in CI resolves the CI glitch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.bazelrcfrom envoy.tryCreateNewConnectionnow returns aConnPoolImplBase::ConnectionResultinstead of abool.Signed-off-by: Jakub Sobon mumak@google.com