Update Envoy to c2522c69f (Jan 11th 2021).#604
Merged
mum4k merged 3 commits intoenvoyproxy:masterfrom Jan 13, 2021
mum4k:envoy-update
Merged
Update Envoy to c2522c69f (Jan 11th 2021).#604mum4k merged 3 commits intoenvoyproxy:masterfrom mum4k:envoy-update
mum4k merged 3 commits intoenvoyproxy:masterfrom
mum4k:envoy-update
Conversation
- Envoy::StreamInfo::StreamInfoImpl no longer contains methods that set local and remote socket addresses. It instead requires a Envoy::Network::SocketAddressProviderSharedPtr with the addresses already set. Pass in a Envoy::Network::SocketAddressSetterImpl so that we can continue setting the remote address for tests. Signed-off-by: Jakub Sobon <mumak@google.com>
Collaborator
Author
|
@qqustc please review and assign back to me when done. |
oschaaf
reviewed
Jan 12, 2021
Member
oschaaf
left a comment
oschaaf
left a comment
There was a problem hiding this comment.
The code changes LGTM, but checking I noticed that Envoy's https://github.com/envoyproxy/envoy/blob/master/.bazelversion and https://github.com/envoyproxy/envoy/blob/master/.bazelrc have fairly recent changes.
Do we want to mirror those in this update?
oschaaf
added
waiting-for-changes
Signed-off-by: Jakub Sobon <mumak@google.com>
Collaborator
Author
|
Thanks for pointing that out @oschaaf, copied |
oschaaf
added
waiting-for-review
qqustc
previously approved these changes
Jan 13, 2021
Signed-off-by: Jakub Sobon <mumak@google.com>
Collaborator
Author
|
@oschaaf please take another look and approve when ready. |
mum4k
added
waiting-for-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Envoy::StreamInfo::StreamInfoImplno longer contains methods that set local and remote socket addresses. It instead requires aEnvoy::Network::SocketAddressProviderSharedPtrwith the addresses already set. Pass in aEnvoy::Network::SocketAddressSetterImplso that we can continue setting the remote address for tests..bazelversionand.bazelrcfrom Envoy.Signed-off-by: Jakub Sobon mumak@google.com