Update Envoy to 867b9e23d2e48350bd1b0d1fbc392a8355f20e35#599
Merged
dubious90 merged 1 commit intoenvoyproxy:masterfrom Dec 21, 2020
Merged
Update Envoy to 867b9e23d2e48350bd1b0d1fbc392a8355f20e35#599dubious90 merged 1 commit intoenvoyproxy:masterfrom
dubious90 merged 1 commit intoenvoyproxy:masterfrom
Conversation
- Unbreak changed allocateConnPool() method usage: changes with respect to ALPN allow negotiation of a protocol, which is backed in Envoy by a pool which supports >1 protocols. This update leaves a code-level comment plus a RELEASE_ASSERT when a multi-protocol pool is allocated. - Avoid MOCK_METHODn as per new check_format objections: Change our mocks to use MOCK_METHOD instead. Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
dubious90
approved these changes
Dec 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with respect to ALPN allow negotiation of a protocol,
which is backed in Envoy by a pool which supports >1
protocols. This update leaves a code-level comment plus
a RELEASE_ASSERT when a multi-protocol pool is allocated.
Change our mocks to use MOCK_METHOD instead.
Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com