Deprecate Envoy API v2 primitives in the service proto for Request Source.#589
Merged
mum4k merged 5 commits intoenvoyproxy:masterfrom Dec 8, 2020
mum4k:request-source-api-v2-to-v3
Merged
Deprecate Envoy API v2 primitives in the service proto for Request Source.#589mum4k merged 5 commits intoenvoyproxy:masterfrom mum4k:request-source-api-v2-to-v3
mum4k merged 5 commits intoenvoyproxy:masterfrom
mum4k:request-source-api-v2-to-v3
Conversation
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Signed-off-by: Jakub Sobon <mumak@google.com>
Collaborator
Author
|
@dubious90 please review and assign back to me once done. |
dubious90
previously approved these changes
Dec 4, 2020
Contributor
dubious90
left a comment
dubious90
left a comment
There was a problem hiding this comment.
Looks good modulo the one copy-paste error
oschaaf
previously approved these changes
Dec 5, 2020
Member
oschaaf
left a comment
oschaaf
left a comment
There was a problem hiding this comment.
LGTM, but one thought I wanted to float for consideration. LGTM if you lean towards keeping this as is.
Signed-off-by: Jakub Sobon <mumak@google.com>
Collaborator
Author
|
@oschaaf @dubious90 Could one of you take another look and re-approve after addressing the comments? Thank you. |
oschaaf
approved these changes
Dec 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converting the current field into a
oneofand marking thev2primitive as deprecated. The old field retains its functionality for backward compatibility.Also:
api/request_source/service.proto.v3primitive.test/request_stream_grpc_client_test.cc, the current message just dumps byte representation of the two compared header objects.Fixes #580.
Signed-off-by: Jakub Sobon mumak@google.com